Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a6e23292464eb7dac1c9150fb0bde7a3e7b211a2
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 49bb1c6832a7f142ddabcb5d8f55ea35d576752c
Choose a head ref
  • 2 commits
  • 8 files changed
  • 1 contributor

Commits on Jul 15, 2022

  1. deps: V8: backport f3cad8cec656 

    Original commit message:

    [serializer] allow SnapshotCreator to destruct without a blob

    Previously SnapshotCreator demanded a blob to be created before
    it can be destructed in debug build, this patch removes the
    DCHECK so that the embedder can choose not to create the blob
    when e.g. the snapshot building isn't successful due to errors.

    Change-Id: I72939be1e0d79b257b9761f48a72e45325a1f6d8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716682
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#81644}

Refs: v8/v8@f3cad8c

PR-URL: #43531
Refs: #35711
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @joyeecheung
    joyeecheung committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    9bfabe8 View commit details
    Browse the repository at this point in the history

  2. bootstrap: handle snapshot errors gracefully 

    This patch refactors the SnapshotBuilder::Generate() routines
so that when running into errors during the snapshot building
process, they can exit gracefully by printing the error
and return a non-zero exit code. If the error is likely to
be caused by internal scripts, the return code would be 12,
if the error is caused by user scripts the return code would
be 1. In addition this refactors the generation of embedded
snapshots and directly writes to the output file stream
instead of producing an intermediate string with string
streams.

PR-URL: #43531
Refs: #35711
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @joyeecheung
    joyeecheung committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    49bb1c6 View commit details
    Browse the repository at this point in the history
Loading