Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fa5af0d50846083fcd0bb9de6006bb57424a17cf
Choose a base ref
...
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 842a35fbac5c29e8bb095fe3716375232ee0d0ce
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Jan 10, 2019

  1. buffer: move initialization of buffer prototype into node.js 

    Instead of exposing it in `lib/internal/buffer.js` after deleting
it from the binding and then do the initialization in
`lib/buffer.js`, which results in an implicit dependency on
the order in which these modules are loaded.

PR-URL: #25292
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    97f59b9 View commit details
    Browse the repository at this point in the history

  2. buffer: move Buffer prototype wiring into internal/buffer.js 

    Instead of exposing the Buffer prototype methods through an
object in `internal/buffer.js` and then iterating over it
to put the methods on the prototype, create a function
in `internal/buffer.js` to do this.

Also moves the creaton of the `FastBuffer` class into
`internal/buffer.js` and expose it directly instead of
writing it onto that module later.

PR-URL: #25292
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @joyeecheung
    joyeecheung committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    842a35f View commit details
    Browse the repository at this point in the history
Loading