Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--enable-static produces thin archives on Linux #30335

Closed
branchseer opened this issue Nov 8, 2019 · 3 comments
Closed

--enable-static produces thin archives on Linux #30335

branchseer opened this issue Nov 8, 2019 · 3 comments
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers.

Comments

@branchseer
Copy link
Contributor

branchseer commented Nov 8, 2019

This makes it inconvenient to distribute Node.js as a prebuilt static library for embedders.

Based on what I learned from #7957 (comment), thin archives save space and compilation time, and they are turned off if the build target is a static library and the OS is solaris.

Shouldn't the operator be or instead of and? From what I understand SmartOS can't handle thin archives so they should be disabled whatever the build target is.

@branchseer
Copy link
Contributor Author

cc: @bnoordhuis

@bnoordhuis bnoordhuis added the build Issues and PRs related to build files or the CI. label Nov 8, 2019
@bnoordhuis
Copy link
Member

standalone_static_library is only relevant when building a static archive. gyp raises an error when you try to enable it for a non-static library build, hence the and.

@bnoordhuis
Copy link
Member

I'm closing this as answered, cheers.

@bnoordhuis bnoordhuis added the question Issues that look for answers. label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

2 participants