-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http spec says url/query-sting should be unlimited. this can't be set programatically. #32290
Comments
This does not give you the maximum header size for a specific server, only the global default. |
So how do I find what it is set to? For sure it does not set it because I have a long query string that works when I set it w/ CLI, but does not work when I set it programmatically. |
Ah, right, that should have been documented. |
@addaleax How do I get the handle to the server ? I'm using this from express like so: But in any case in my testing, the maxHeaderSize is not set because it 'blocks' a large request |
const server = http.createServer({maxHeaderSize: 16000 }, ExpInst).listen(8080)
console.warn(server.maxHeaderSize)
Okay, but without an example/reproduction and information about your system such as Node.js version, there’s really nothing we can do. |
This seems like a good place for getting into the project. |
@addaleax I wrote a test to prove it does not work: |
Above does not set the maxHeaderSize. Yes you can do it from CLI, but you should be able to set it programatically.
#24692
expressjs/express#4218
The text was updated successfully, but these errors were encountered: