v20.7.0 build fails in torque-generated/src/builtins/builtins-string-tq-csa.cc

[yanovich]

Version

v20.7.0

Platform

Linux host33 6.2.0-32-generic #32-Ubuntu SMP PREEMPT_DYNAMIC Mon Aug 14 10:03:50 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

torque-generated/src/builtins/builtins-string-tq-csa.cc

What steps will reproduce the bug?

$ nvm install -s v20.7.0

Which is equivalent to:

$ ./configure --prefix=/home/s/.nvm/versions/node/v20.7.0
$ make -j 11

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Build succeeds.

What do you see instead?

In file included from /usr/include/c++/12/unordered_map:47,
                 from /usr/include/c++/12/functional:61,
                 from ../deps/v8/src/base/template-utils.h:9,
                 from ../deps/v8/src/base/logging.h:17,
                 from ../deps/v8/src/base/macros.h:12,
                 from ../deps/v8/src/base/bits.h:12,
                 from ../deps/v8/src/base/hashmap.h:14,
                 from ../deps/v8/src/ast/ast-value-factory.h:33,
                 from ../deps/v8/src/ast/ast.h:10,
                 from /home/s/.nvm/.cache/src/node-v20.7.0/files/out/Release/obj/gen/torque-generated/src/builtins/array-tq-csa.cc:1:
/usr/include/c++/12/bits/unordered_map.h: In instantiation of ‘class std::unordered_map<v8::internal::MemoryChunk*, long int>’:
../deps/v8/src/heap/incremental-marking.h:268:46:   required from here
/usr/include/c++/12/bits/unordered_map.h:121:57: error: type/value mismatch at argument 2 in template parameter list for ‘template<class _Key, class _Tp, class _Hash, class _Pred, class _Alloc> typedef typename std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::_Hashtable::pointer std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::pointer’
  121 |       typedef typename _Hashtable::pointer              pointer;
      |                                                         ^~~~~~~
/usr/include/c++/12/bits/unordered_map.h:121:57: note:   expected a type, got ‘<expression error>’

Additional information

$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 12.3.0-1ubuntu1~23.04' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-12 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-12-DAPbBt/gcc-12-12.3.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-12-DAPbBt/gcc-12-12.3.0/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.3.0 (Ubuntu 12.3.0-1ubuntu1~23.04) 

It's a regression. v20.6.0 builds just fine.

[bnoordhuis]

It's a regression. v20.6.0 builds just fine.

It's not a regression but a compiler bug in gcc.

I'm hitting it too but none of the relevant files changed between v20.6.0 and v20.7.0. I don't think there's really anything we can do because the input is syntactically valid. Try downgrading gcc or switching to clang.

[bnoordhuis]

I'll go ahead and close this as "inactionable, not-our-bug" but thanks anyway for the report.