Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: make the dot reporter colored #51770

Open
mcollina opened this issue Feb 15, 2024 · 4 comments · May be fixed by #53450
Open

test_runner: make the dot reporter colored #51770

mcollina opened this issue Feb 15, 2024 · 4 comments · May be fixed by #53450
Labels
good first issue Issues that are suitable for first-time contributors. test_runner

Comments

@mcollina
Copy link
Member

Currently the dot reporter prints white dots and white X. I think it should print green dots and red X.
@mcollina mcollina added good first issue Issues that are suitable for first-time contributors. test_runner labels Feb 15, 2024
@bantoinese83
Copy link

Hi @mcollina, I'm interested in working on this issue. Could you please provide more details or guidance to get started? Thanks!

@bantoinese83 bantoinese83 mentioned this issue Feb 16, 2024
Closed
Aidan7757 pushed a commit to Aidan7757/node that referenced this issue Mar 30, 2024
lib: changed the colors of X's and .'s in test_runner dot reporter to…
03d7421 
… add red and green.

Fixes: nodejs#51770
@Aidan7757 Aidan7757 mentioned this issue Mar 30, 2024
Closed
Aidan7757 pushed a commit to Aidan7757/node that referenced this issue Apr 1, 2024
lib: changed the colors of X's and .'s in test_runner dot reporter
5e96c1e 
Fixes: nodejs#51770
@Dishantydv7
Copy link

Hey , i would love to contribute to this issue , can u provide me the brief over it .

@mcollina
Copy link
Member Author

mcollina commented Jun 8, 2024

What's not clear about it? The outcome is that the output of the dot reporter has colors.

@RedYetiDev
Copy link
Member

Hey , i would love to contribute to this issue , can u provide me the brief over it .

(note that #52278 may accomplish this)

puskin94 pushed a commit to puskin94/node that referenced this issue Jun 14, 2024
lib: adding colors to the xs and dots in the test runner
1afbf33 
Fixes: nodejs#51770
@puskin94 puskin94 linked a pull request Jun 14, 2024 that will close this issue
Open
puskin94 pushed a commit to puskin94/node that referenced this issue Jun 15, 2024
test_runner: adding colors to the xs and dots in the test runner
46a5fce 
Fixes: nodejs#51770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. test_runner
Projects
None yet
Milestone
No milestone
4 participants
@mcollina @RedYetiDev @bantoinese83 @Dishantydv7