From 2ebdd3e408faade5fcfdddd44c213f58bf06c14b Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Thu, 1 Nov 2018 15:15:56 -0400 Subject: [PATCH 1/3] doc: add dco to github pr template Our project relies on the Developer Certificate of Origin as a passive alternative to a Contributor License Agreement. The PR template seems like a great place to surface the text to help new contributors be aware of the DCO and it's implications. --- .github/PULL_REQUEST_TEMPLATE.md | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f85c224898db30..445dc37877bb62 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,3 +14,32 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) + + From be82314d07076dfaff79f9e78f6ef80c566b5474 Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Thu, 1 Nov 2018 16:00:23 -0400 Subject: [PATCH 2/3] fixup: remove anchor --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 445dc37877bb62..e315a3af41426e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -16,7 +16,6 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)