From 628df7913a35975148a829b01425d8b12e31acd3 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 15 May 2024 07:40:23 -0400 Subject: [PATCH 1/2] cli: allow `--test-[name/skip]-pattern` in `NODE_OPTIONS` --- src/node_options.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/node_options.cc b/src/node_options.cc index ebbe804d364f10..22f6341690d5a5 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -628,7 +628,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { &EnvironmentOptions::test_runner_coverage); AddOption("--test-name-pattern", "run tests whose name matches this regular expression", - &EnvironmentOptions::test_name_pattern); + &EnvironmentOptions::test_name_pattern, + kAllowedInEnvvar); AddOption("--test-reporter", "report test output using the given reporter", &EnvironmentOptions::test_reporter, @@ -647,7 +648,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { kAllowedInEnvvar); AddOption("--test-skip-pattern", "run tests whose name do not match this regular expression", - &EnvironmentOptions::test_skip_pattern); + &EnvironmentOptions::test_skip_pattern, + kAllowedInEnvvar); AddOption("--test-udp-no-try-send", "", // For testing only. &EnvironmentOptions::test_udp_no_try_send); AddOption("--throw-deprecation", From ae26ffbc4d1453f487bbb8ded12676347e8bee94 Mon Sep 17 00:00:00 2001 From: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com> Date: Wed, 15 May 2024 07:46:03 -0400 Subject: [PATCH 2/2] doc: add arguments to NODE_OPTIONS (cli.md) --- doc/api/cli.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/api/cli.md b/doc/api/cli.md index 7c95014395f6f8..26b5b9284742fb 100644 --- a/doc/api/cli.md +++ b/doc/api/cli.md @@ -2721,10 +2721,12 @@ one is included in the list below. * `--secure-heap-min` * `--secure-heap` * `--snapshot-blob` +* `--test-name-pattern` * `--test-only` * `--test-reporter-destination` * `--test-reporter` * `--test-shard` +* `--test-skip-pattern` * `--throw-deprecation` * `--title` * `--tls-cipher-list`