Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require TSC approval for stances #6772

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

benjamingr
Copy link
Member

@nodejs/tsc , bikeshedding/different wording welcome

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@nodejs/tsc , bikeshedding/different wording welcome

Signed-off-by: Benjamin Gruenbaum <benjamingr@gmail.com>
@benjamingr benjamingr requested a review from a team as a code owner June 2, 2024 18:05
Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 3, 2024 8:58am

GOVERNANCE.md Outdated Show resolved Hide resolved
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all it's worth, I appreciate the TSC proactively handling this.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

GOVERNANCE.md Outdated Show resolved Hide resolved
@bmuenzenmeyer
Copy link
Collaborator

Does anyone have strong opinions about how this relates to CONTENT VS CODE?

I think if I had to pick, I'd see it as content. Reading those guidelines in accordance with this change, I'd resolve to say it re-enforces TSC involvement. Perhaps they should be cross-linked.

Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Benjamin Gruenbaum <inglor@gmail.com>
@ovflowd
Copy link
Member

ovflowd commented Jun 2, 2024

Does anyone have strong opinions about how this relates to CONTENT VS CODE?

I think if I had to pick, I'd see it as content. Reading those guidelines in accordance with this change, I'd resolve to say it re-enforces TSC involvement. Perhaps they should be cross-linked.

cc @nodejs/tsc

@ovflowd
Copy link
Member

ovflowd commented Jun 3, 2024

Standard governance changes within this repository require an extended period for approval. But I can't imagine the TSC or the Web Team would be against this change. To be honest, we can merge this as soon as possible. But I'm also fine waiting the 72 hours.

I'd like @bmuenzenmeyer's concern addressed before we merge this, just so we can easily clarify/connect both documents, which serve as a guiding mechanism.

Is the TSC OK if we update the docs of CONTENT_VS_CODE to match governance changes?

@benjamingr
Copy link
Member Author

. Standard governance changes within this repository require an extended period for approval. But I can't imagine the TSC or the Web Team would be against this change. To be honest, we can merge this as soon as possible. But I'm also fine waiting the 72 hours.

Please do not merge this until 48h have passed or at least TSC members have had time to look when back from the weekend.

GOVERNANCE.md Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Claudio W <cwunder@gnome.org>
@jasnell
Copy link
Member

jasnell commented Jun 3, 2024

I think it should likely be stressed that this is not a gatekeeping measure meant to discourage these kinds of changes but more of an awareness thing. Specifically, the TSC needs to be given the time to be aware that such changes are proposed/pending and given the time to weigh in on the possible ramifications of the change.

@benjamingr
Copy link
Member Author

@jasnell I've tried to use as neutral objective language in the text but feel free to suggest edits if you think it implies a bias against or for such initiatives.

@RedYetiDev
Copy link
Member

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Jun 3, 2024

I'm not suggesting that any changes be made to the proposed text (otherwise I would have made that explicit)... I just wanted to stress the point in the PR discussion here.

@bmuenzenmeyer
Copy link
Collaborator

48 hours have passed. appreciate the strong alignment on this one

@bmuenzenmeyer bmuenzenmeyer merged commit 3ccaf03 into main Jun 4, 2024
5 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the tsc-approval-goverance branch June 4, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.