Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers#set returns Map #2431

Closed
tsctx opened this issue Nov 13, 2023 · 0 comments · Fixed by #2432
Closed

Headers#set returns Map #2431

tsctx opened this issue Nov 13, 2023 · 0 comments · Fixed by #2432
Labels
bug Something isn't working

Comments

@tsctx
Copy link
Member

tsctx commented Nov 13, 2023 •
edited
Loading

Bug Description

Headers#set returns Map

Reproducible By

console.log(new Headers().set("x", "0") instanceof Map); // true

Expected Behavior

console.log(new Headers().set("x", "0") instanceof Map); // false

Logs & Screenshots

> $ node
Welcome to Node.js v21.1.0.
Type ".help" for more information.
> new Headers().set("x", "0") instanceof Map
true

Environment

Additional context
@tsctx tsctx added the bug Something isn't working label Nov 13, 2023
@tsctx tsctx mentioned this issue Nov 13, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement Headers#set correctly tsctx/undici
1 participant
@tsctx