From 98473c2a84b4f07dde384e71d983c01fcbab0a1d Mon Sep 17 00:00:00 2001 From: Khafra Date: Wed, 5 Jun 2024 13:44:44 -0400 Subject: [PATCH 1/3] remove websocket experimental warning --- lib/web/websocket/websocket.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js index 83d4ee94e30..109d7be2e2f 100644 --- a/lib/web/websocket/websocket.js +++ b/lib/web/websocket/websocket.js @@ -28,8 +28,6 @@ const { types } = require('node:util') const { ErrorEvent, CloseEvent } = require('./events') const { SendQueue } = require('./sender') -let experimentalWarned = false - // https://websockets.spec.whatwg.org/#interface-definition class WebSocket extends EventTarget { #events = { @@ -56,13 +54,6 @@ class WebSocket extends EventTarget { const prefix = 'WebSocket constructor' webidl.argumentLengthCheck(arguments, 1, prefix) - if (!experimentalWarned) { - experimentalWarned = true - process.emitWarning('WebSockets are experimental, expect them to change at any time.', { - code: 'UNDICI-WS' - }) - } - const options = webidl.converters['DOMString or sequence or WebSocketInit'](protocols, prefix, 'options') url = webidl.converters.USVString(url, prefix, 'url') From add33aebbb0404d3ae17a782ac4182c8f5a457f7 Mon Sep 17 00:00:00 2001 From: Khafra Date: Wed, 5 Jun 2024 13:50:56 -0400 Subject: [PATCH 2/3] ?? --- test/node-test/debug.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/node-test/debug.js b/test/node-test/debug.js index d7c462f57ae..e8395e07360 100644 --- a/test/node-test/debug.js +++ b/test/node-test/debug.js @@ -22,9 +22,6 @@ test('debug#websocket', { skip: !process.versions.icu }, async t => { const chunks = [] const assertions = [ /(WEBSOCKET [0-9]+:) (connecting to)/, - // Skip the chunk that comes with the experimental warning - /(\[UNDICI-WS\])/, - /\(Use `node --trace-warnings \.\.\.` to show where the warning was created\)/, /(WEBSOCKET [0-9]+:) (connected to)/, /(WEBSOCKET [0-9]+:) (sending request)/, /(WEBSOCKET [0-9]+:) (connection opened)/, From 2217a544d508b55de8015f76e943695ba10e57b2 Mon Sep 17 00:00:00 2001 From: Khafra Date: Wed, 5 Jun 2024 21:20:15 -0400 Subject: [PATCH 3/3] fixup --- test/node-test/debug.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/node-test/debug.js b/test/node-test/debug.js index e8395e07360..16de2f2883f 100644 --- a/test/node-test/debug.js +++ b/test/node-test/debug.js @@ -9,7 +9,7 @@ const { tspl } = require('@matteo.collina/tspl') const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g test('debug#websocket', { skip: !process.versions.icu }, async t => { - const assert = tspl(t, { plan: 8 }) + const assert = tspl(t, { plan: 6 }) const child = spawn( process.execPath, [join(__dirname, '../fixtures/websocket.js')],