Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expands information for local compilations, clarify not all recipes builds #125

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

mckaygerhard
Copy link
Contributor

This little change in the README.md helps and closes #123 due a rare error like ccache: error: Could not find compiler "g++" in PATH .. instructions was improved for non familiar with nodejs build process

Aditional, apparently not all recipes compile in all flavors, I have noticed, for example, that in 16.x.y they only compile some while in 20.x.y they compile almost all of them. i noted this also in the alredy released tarball, by example https://unofficial-builds.nodejs.org/download/release/v20.11.1/ already have almost all recipes .. but for https://unofficial-builds.nodejs.org/download/release/v16.20.2/ i noted there is not x64-glibc-217 recipe released..

…ill build

* helps and closes nodejs#123
  due a rare error like `ccache: error: Could not find compiler "g++" in PATH`
README.md Outdated Show resolved Hide resolved
Comment on lines +105 to +107
rm -fr ~/Devel/unofficial-builds-home
mkdir -p ~/Devel/unofficial-builds-home
cd ~/Devel/unofficial-builds-home
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should ditch the ~/Deve/ prefixes here, let the user do it in cwd or edit this themselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did to avoid mixed files in home, most of users works not so organized .. we must promoted organization but i dont know how to promoted such thing.. what do you suggest? this allows people to know easyle that all related files is under that path only

Copy link
Contributor Author

@mckaygerhard mckaygerhard Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact @rvagg the command with such prefixed helps to understand to others (that are not English native speakers) the confusion of "homedir"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, fair enough and you have documented it below that this is what you're doing. What stands out to me is "Devel" though, it's not a standard thing, looks macOSish, and the user is inevitably going to have to edit that. So maybe just ditch the "/Devel" from your commands and run with ~/unofficial-builds-home.

Copy link
Contributor Author

@mckaygerhard mckaygerhard Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok b eore changin.. as last attempt to defend my point, it is not a macshish but just like this Downloads, and like XDG in linux has Public or Music several subdirectories, in the original text i thought thinked i was forced to use home directly since due to language barriers you always think that it is understood very well, but the examples are essential, if even with this explanation I cannot convince you then I change it as you suggest, but i am here cos many others just get tyred of put issues with questions that canot xperess in good way.. developers always thnks have reason but we are first humans.. that's why i put later $workdir will be ~/Devel/unofficial-builds-home

README.md Outdated Show resolved Hide resolved
mckaygerhard and others added 2 commits March 26, 2024 12:58
nodejs#125 (review)

Co-authored-by: Rod Vagg <rod@vagg.org>
…tions


nodejs#125 (review)

yes, sorry, mabe was better "recipe & versions combinations" but well.. we already address that in nodejs#123

Co-authored-by: Rod Vagg <rod@vagg.org>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented Apr 8, 2024

ok, I don't think I care enough about the ~/Devel thing and I appreciate this contribution, thanks @mckaygerhard !

@rvagg rvagg merged commit 0ab9c92 into nodejs:main Apr 8, 2024
@mckaygerhard
Copy link
Contributor Author

ok, I don't think I care enough about the ~/Devel thing and I appreciate this contribution, thanks @mckaygerhard !

sorry about the large explanation.. i now will make some packages around your helps! i hope some people understand the adition and feel free to change it if does not help 👍

@mckaygerhard mckaygerhard deleted the readme-improve-local-instructions branch April 9, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help on local builds, error on tmp, seems Dockerfiles must be edited for volumes ?
2 participants