Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local_build.sh logic is broken (may be affecting prod build as well) #137

Closed
scosol opened this issue Apr 12, 2024 · 2 comments
Closed

local_build.sh logic is broken (may be affecting prod build as well) #137

scosol opened this issue Apr 12, 2024 · 2 comments

Comments

@scosol
Copy link
Contributor

scosol commented Apr 12, 2024

local_build.sh is expecting "[WORKDIR]../../var/build_queue" to exist and the script fails until:

mkdir ../../var
touch ../../var/build_queue

Then the script succeeds

local_build.sh calls the same things used by the automated production build and I am worried that the current automated build is working off of the old(existing) build_queue instead of the new build_queue in the new location because of this.
(causing none of the targets I fixed, to be built)

not sure what the reasoning was for refactoruing the location of things, but without access to the actual build server my level of assistance here is going to be limited

@rvagg
Copy link
Member

rvagg commented Apr 19, 2024

don't suppose you could submit a PR to deal with this? it's a fairly new script and there was an attempt to share logic with the server build script which is why you're seeing this. it works on my machine because I have it set up like this so obviously haven't noticed.

@scosol
Copy link
Contributor Author

scosol commented Apr 22, 2024

#140

@scosol scosol closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants