Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.4.0 build failed #87

Closed
tim-richter opened this issue Jul 6, 2023 · 4 comments
Closed

v20.4.0 build failed #87

tim-richter opened this issue Jul 6, 2023 · 4 comments

Comments

@tim-richter
Copy link
Contributor

Hi 馃憢 Latest release is currently empty (https://unofficial-builds.nodejs.org/download/release/v20.4.0/), because the build failed in fetch-source https://unofficial-builds.nodejs.org/logs/202307051402-v20.4.0/fetch-source.log.

Something similar also happened in #86. Not sure exactly what the issue here is.

@rvagg
Copy link
Member

rvagg commented Jul 7, 2023

Well that's pretty annoying. Happening twice makes it a pattern. This should be hitting Cloudflare, but there's a small chance that we're the first client to download that file when it's newly promoted so maybe there's a cache issue here. 馃し I'll requeue it.

@tim-richter
Copy link
Contributor Author

Maybe adding a retry for that particular curl request would already suffice? I'm not that familiar with this project, but I could try adding that to fetch-source

@rvagg
Copy link
Member

rvagg commented Jul 7, 2023

yep, that might be a good thing to do, loop a few times with a sleep between

@tim-richter
Copy link
Contributor Author

Opened a PR for this #88.
The 20.4 build was successful tho, so I will close this issue. Thanks @rvagg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants