Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loong64 and riscv are missing from the index #97

Closed
wangling12 opened this issue Sep 8, 2023 · 3 comments
Closed

Loong64 and riscv are missing from the index #97

wangling12 opened this issue Sep 8, 2023 · 3 comments

Comments

@wangling12
Copy link
Contributor

At least there are riscv and loong64 tars in https://unofficial-builds.nodejs.org/download/release/v20.6.0/

But it seems that these architectures are missing in ndex.json and index.tab.

@rvagg
Copy link
Member

rvagg commented Sep 8, 2023

oh, good catch; we probably need to update https://github.com/nodejs/nodejs-dist-indexer/blob/main/transform-filename.js#L37-L42

would you mind opening a pull request to add the missing ones there? we also might need something on the README here to remind people when adding new types

@wangling12
Copy link
Contributor Author

Finished, hope there are nothing wrong in prs.

@rvagg
Copy link
Member

rvagg commented Sep 10, 2023

old:

{"version":"v20.6.1","date":"2023-09-08","files":["headers","linux-armv6l","linux-x64-musl","linux-x64-pointer-compression"],"npm":"9.8.1","v8":"11.3.244.8","uv":"1.46.0","zlib":"1.2.13.1-motley","openssl":"3.0.10+quic","modules":"115","lts":false,"security":false},

new:

{"version":"v20.6.1","date":"2023-09-08","files":["headers","linux-armv6l","linux-loong64","linux-riscv64","linux-x64-glibc-217","linux-x64-musl","linux-x64-pointer-compression"],"npm":"9.8.1","v8":"11.3.244.8","uv":"1.46.0","zlib":"1.2.13.1-motley","openssl":"3.0.10+quic","modules":"115","lts":false,"security":false},

thanks for the contribution!

@rvagg rvagg closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants