Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'releaseonEdges' option doesn't work #6770

Closed
5 of 6 tasks
Craigy- opened this issue Jun 20, 2023 · 0 comments · May be fixed by Aarod23/nys-site#1
Closed
5 of 6 tasks

'releaseonEdges' option doesn't work #6770

Craigy- opened this issue Jun 20, 2023 · 0 comments · May be fixed by Aarod23/nys-site#1

Comments

@Craigy-
Copy link

Craigy- commented Jun 20, 2023

Check that this is really a bug

  • I confirm

Reproduction link

https://craigy.ru/t/hakobian

Bug description

Seems like this option of Mousewheel module doesn't work.

Sorry for no pull request but I think an error in \src\modules\mousewheel\mousewheel.js on strings 388-389:

// Return page scroll on edge positions
if (position === swiper.minTranslate() || position === swiper.maxTranslate()) return true;

It works for me like this:

// Return page scroll on edge positions
if (params.releaseOnEdges && (position === swiper.minTranslate() || position === swiper.maxTranslate())) return true;

Expected Behavior

No response

Actual Behavior

No response

Swiper version

9.4.1

Platform/Target and Browser Versions

Windows 10 Home, all browsers

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant