Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android autofocus restriction to allow more phones to be compatible #718

Closed
Tbaut opened this issue Feb 5, 2021 · 0 comments · Fixed by #793
Closed

Remove android autofocus restriction to allow more phones to be compatible #718

Tbaut opened this issue Feb 5, 2021 · 0 comments · Fixed by #793

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Feb 5, 2021

We just had a report by a user that their phone isn't compatible with Signer. By checking more in details, the phone is only a couple years old, and runs android 8 or 9, which is definitely supported. Last I checked it runs fine on android 7.

checking a little deeper, it looks like we require the phone to support autofocus. Which this phone is not marked as supporting. This is obviously a little weird, since the phone 100% has autofocus.

We should try to remove this restriction in our manifest and see if this has any bad consequence on the building of the app.

image

@Tbaut Tbaut changed the title Allow more phones to be compatible Remove android autofocus restriction to allow more phones to be compatible Feb 5, 2021
@Slesarew Slesarew linked a pull request Aug 25, 2021 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant