Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(update-notifier): don't force black background #3499

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

wraithgar
Copy link
Member

This looks very wrong on white terminals.

npmlog still makes its notice logs do this but that will have to be
fixed in the npmlog repo.

References

Related to #3091

@wraithgar wraithgar requested a review from a team as a code owner July 1, 2021 22:48
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Jul 12, 2021
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good call, we definitely shouldn't be forcing background colors unless we absolutely have to.. and we don't.

This looks very wrong on white terminals.

npmlog still makes its `notice` logs do this but that will have to be
fixed in the npmlog repo.

PR-URL: #3499
Credit: @wraithgar
Close: #3499
Reviewed-by: @nlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants