Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scripts in workspace root should ignore workspaces #155

Closed
lukekarrys opened this issue Jul 28, 2022 · 0 comments · Fixed by #189
Closed

feat: scripts in workspace root should ignore workspaces #155

lukekarrys opened this issue Jul 28, 2022 · 0 comments · Fixed by #189

Comments

@lukekarrys
Copy link
Contributor

lukekarrys commented Jul 28, 2022

When running things like npm run lint and npm test in the root of a monorepo, the globs pick up paths in workspaces.

I think we should do two things in our generated files:

  • In a workspace root, generate ignore patterns for any workspace dirs
  • If the workspace root is not a package of its own and only exists to hold the workspaces, npm run lint and npm test should be wrappers around npm run lint -ws and npm test -ws.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant