From 503a104e9d549853ad75189e81c0f7704873cb3e Mon Sep 17 00:00:00 2001 From: tpodolak Date: Sun, 1 Jul 2018 23:47:06 +0200 Subject: [PATCH] [GH-18] - removing non-common use cases from shared verifier interface --- .../INonVirtualSetupWhenDiagnosticVerifier.cs | 12 ------- ...ReturnsForAnyArgsAsExtensionMethodTests.cs | 1 - .../NonVirtualSetupWhenDiagnosticVerifier.cs | 12 ------- .../WhenAsExtensionMethodTests.cs | 36 ------------------- .../WhenAsOrdinaryMethodTests.cs | 36 ------------------- ...naryMethodWithGenericTypeSpecifiedTests.cs | 36 ------------------- .../WhenForAnyArgsAsExtensionMethodTests.cs | 36 ------------------- .../WhenForAnyArgsAsOrdinaryMethodTests.cs | 36 ------------------- ...naryMethodWithGenericTypeSpecifiedTests.cs | 36 ------------------- 9 files changed, 241 deletions(-) diff --git a/tests/NSubstitute.Analyzers.Tests.Shared/DiagnosticAnalyzers/INonVirtualSetupWhenDiagnosticVerifier.cs b/tests/NSubstitute.Analyzers.Tests.Shared/DiagnosticAnalyzers/INonVirtualSetupWhenDiagnosticVerifier.cs index 59fd2090..d698cedb 100644 --- a/tests/NSubstitute.Analyzers.Tests.Shared/DiagnosticAnalyzers/INonVirtualSetupWhenDiagnosticVerifier.cs +++ b/tests/NSubstitute.Analyzers.Tests.Shared/DiagnosticAnalyzers/INonVirtualSetupWhenDiagnosticVerifier.cs @@ -34,20 +34,8 @@ public interface INonVirtualSetupWhenDiagnosticVerifier Task ReportsDiagnostics_WhenSettingValueForNonVirtualIndexer(string whenAction, int expectedLine, int expectedColumn); - Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction(); - - Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction(); - Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularFunction(); - Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction(); - - Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction(); - - Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction(); - Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularFunction(); - - Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction(); } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupAnalyzerTests/ReturnsForAnyArgsAsExtensionMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupAnalyzerTests/ReturnsForAnyArgsAsExtensionMethodTests.cs index 30158840..402a2037 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupAnalyzerTests/ReturnsForAnyArgsAsExtensionMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupAnalyzerTests/ReturnsForAnyArgsAsExtensionMethodTests.cs @@ -1,7 +1,6 @@ using System.Threading.Tasks; using Microsoft.CodeAnalysis; using NSubstitute.Analyzers.Shared; -using NSubstitute.Analyzers.Tests.Shared; using NSubstitute.Analyzers.Tests.Shared.DiagnosticAnalyzers; namespace NSubstitute.Analyzers.Tests.VisualBasic.DiagnosticAnalyzersTests.NonVirtualSetupAnalyzerTests diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/NonVirtualSetupWhenDiagnosticVerifier.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/NonVirtualSetupWhenDiagnosticVerifier.cs index e32860f3..77c6e1ec 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/NonVirtualSetupWhenDiagnosticVerifier.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/NonVirtualSetupWhenDiagnosticVerifier.cs @@ -37,22 +37,10 @@ public abstract class NonVirtualSetupWhenDiagnosticVerifier : VisualBasicDiagnos public abstract Task ReportsDiagnostics_WhenSettingValueForNonVirtualIndexer(string whenAction, int expectedLine, int expectedColumn); - public abstract Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction(); - - public abstract Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction(); - public abstract Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularFunction(); - public abstract Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction(); - - public abstract Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction(); - - public abstract Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction(); - public abstract Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularFunction(); - public abstract Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction(); - protected override DiagnosticAnalyzer GetDiagnosticAnalyzer() { return new NonVirtualSetupWhenAnalyzer(); diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsExtensionMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsExtensionMethodTests.cs index 6e1657df..32fcb9f1 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsExtensionMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsExtensionMethodTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodTests.cs index e731f3d8..b03dc360 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs index f7644a4a..0a0fd322 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsExtensionMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsExtensionMethodTests.cs index 9fcc0b63..185abe64 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsExtensionMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsExtensionMethodTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodTests.cs index dc847ca6..8bba7bb5 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file diff --git a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs index d1ead803..d896c2a2 100644 --- a/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs +++ b/tests/NSubstitute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/NonVirtualSetupWhenAnalyzerTests/WhenForAnyArgsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs @@ -596,41 +596,5 @@ End Namespace await VerifyDiagnostic(source); } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied functions not supported in VB")] - public override Task ReportsDiagnostics_WhenSettingValueForNonVirtualMember_InRegularExpressionBodiedFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InLocalFunction() - { - return Task.CompletedTask; - } - - [Fact(Skip = "Expression bodied local functions not supported in VB")] - public override Task ReportsNoDiagnostics_WhenSettingValueForVirtualMember_InExpressionBodiedLocalFunction() - { - return Task.CompletedTask; - } } } \ No newline at end of file