Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong class applied to accordion #1

Open
jvalkeejarvi opened this issue Jan 3, 2019 · 5 comments
Open

Wrong class applied to accordion #1

jvalkeejarvi opened this issue Jan 3, 2019 · 5 comments

Comments

@jvalkeejarvi
Copy link

panel-group class is applied to accordion element instead accordion class. Styles are incorrect because of wrong class.

I searched the repo and found word panel-group only in following files:

  • bundles/ngx-foundation.es2015.js.map
  • bundles/ngx-foundation.es2015.js
  • bundles/ngx-foundation.umd.js.map
  • bundles/ngx-foundation.umd.min.js.map
  • bundles/ngx-foundation.umd.min.js
  • bundles/ngx-foundation.umd.js
  • accordion/accordion.component.js.map
  • accordion/accordion.component.metadata.json
@jvalkeejarvi
Copy link
Author

Seems like map and metadata files were not updated when related .js files were updated in commit 282444a.

@nthompson777
Copy link
Owner

You are correct with your findings. Thank you for catching this. I will push this update to the repo and NPM later today as a patch.

@nthompson777
Copy link
Owner

Those map files were nuked due to being inaccurate and out of date and were removed for version 1.0.7.

Repository owner locked as resolved and limited conversation to collaborators Jan 8, 2019
Repository owner unlocked this conversation Jan 10, 2019
@nthompson777
Copy link
Owner

I'm reopening this bug for 1.0.8 since it is still applicable with this version/patch.

@nthompson777 nthompson777 reopened this Jan 10, 2019
@jvalkeejarvi
Copy link
Author

jvalkeejarvi commented Jan 21, 2019

Hello again,

is there any news on this? This issue keeps us from using this package at the moment. If there is anything I can do to help you just tell me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants