-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support optional arguments axis, dtype and out for numpy.cumsum #4624
Comments
@yujianll thanks for taking the time to report this and helping to improve Numba. As documented on: https://numba.pydata.org/numba-doc/dev/reference/numpysupported.html
If you try the following it should work: from numba import jit
import numpy as np
@jit(nopython=True)
def error():
weights = np.ones((100, 100))
np.cumsum(weights)
error() |
numpy.cumsum
numpy.cumsum
I have rename the issues and labeled it as a feature request accordingly. |
@yujianll if you need |
@esc Thanks! Do you mean a for loop to each column of the array would be fast as well? |
@yujianll hmmm, not sure, maybe with fortran order that would work well? |
@esc OK, make sense! So convert the array to fortran order (numba supports np.asfortranarray), and then manipulate array on 0 axis? |
@esc I cannot see this. But thanks! |
@esc Thanks! |
I also just ran into this, support for the axis keyword would be appreciated! |
I would also appreciate axis keyword support |
+1 for axis support |
I do not know the codebase in depth and how to implement this feature but if there can be some guidance I am more than happy to put work on this. @esc do you have any pointers about where to start? |
+1 for support on this |
+1 for axis support |
1 similar comment
+1 for axis support |
Reporting a bug
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).
I somehow cannot use numpy.cumsum in no python mode.
Reproducer:
The text was updated successfully, but these errors were encountered: