Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset gw once closed #37

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Unset gw once closed #37

merged 1 commit into from
Mar 14, 2017

Conversation

jameshartig
Copy link
Contributor

If the handler is already closed, then closing it again causes the gzip writer to be in the pool twice and to be closed in the middle of potentially another write.

@jprobinson
Copy link
Contributor

Thanks for putting this together, @fastest963!

Can you please add a test to replicate the problem?

@jameshartig
Copy link
Contributor Author

@jprobinson Thanks and added tests!

@jprobinson
Copy link
Contributor

🌠 thanks!

@jprobinson jprobinson merged commit 3b0c485 into nytimes:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants