-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recheck source code in coap_dtls_new_context() #293
Comments
Unfortunately, it does contain a |
@obgm Wouldn't removing the How about "G_RET_ZERO_OR_FAIL"? |
It is a macro, so this is duplicate source code anyway. But I agree that renaming would be better than nothing. @mrdeep1 do you have an opinion on this? |
The issue with a long macro name is that there is likelihood of exceeding the line length of 80 characters. Many of the GnuTLS examples make the use of just CHECK (which normally triggers and assert()), I decided to prefix with G_ to indicate this was a CHECK for GnuTLS. That said, I am all for better readability of the code making it self documenting where possible. To that end, I would prefer something like G_CHECK_FAIL. |
Sounds good. |
Ok is everyone fine with changing G_CHECK to G_CHECK_FAIL? If so I'll submit a pr, ensuring lines are split when needed. |
@oliness If you are happy to do the work, that is fine by me. |
@oliness Are you going to be able to do this work? |
The implementation of the function “coap_dtls_new_context” does not contain a goto statement. The jump label “fail” can not be reached.
How do you think about to adjust (or delete) a bit of source code here?
The text was updated successfully, but these errors were encountered: