-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make default baseline the previous stable version in the registry #55
Comments
For other folks reading this issue: this logic is already implemented in the GitHub Action that runs This issue is about moving some of that functionality into |
Is the action correctly handling pre-release? imo the default should not select a previous pre-release but the previous stable release |
Good question. Agreed on the desired behavior. Have not tested it but I'd guess it would pick pre-releases like so:
I believe this produces an equivalent result because semver-checking is transitive: if all those transitions are individually valid then |
Expected result
Unfortunately, it is not transitive for pre-release because you are allow to make breaking changes between pre-release versions. |
#92 fixed some related pre-release issues |
With just
cargo semver-checks
in package directory, it should take the current version and select the previous one. For pre-release versions, it should select the previous non-pre-release as breaking changes between prereleases is fine.The text was updated successfully, but these errors were encountered: