Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with book-2nd/protocols/ssh.rst #275

Open
gregbo opened this issue Dec 26, 2021 · 3 comments
Open

problems with book-2nd/protocols/ssh.rst #275

gregbo opened this issue Dec 26, 2021 · 3 comments

Comments

@gregbo
Copy link

gregbo commented Dec 26, 2021

There are several problems with this page. First, include the hyphen ('-') between Diffie and Hellman wherever it occurs. Next, correct the last sentence of the last (full) paragraph on the page to:

computer2 would then accept Alice's session without asking for her credentials.

Finally, carefully define and explain the terms that are used to generate the keys. I would suggest using the Diffie-Hellman Wikipedia page as a reference.

@obonaventure
Copy link
Owner

Please look at github.com/cnp3/ebook which is more up to date

@gregbo
Copy link
Author

gregbo commented Dec 29, 2021

Alright, I'll do that. I was mostly concerned that there is a lot of detail left out of the explanation of the Diffie-Hellman method, such as the special properties of the g, a, and p terms.

@gregbo
Copy link
Author

gregbo commented Jan 3, 2022

I made some changes in gregbo/ebook/protocols/ssh.rst that give more explanation of the terms and a pointer to RFC 4253 that gives additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants