Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about clamp terms #36

Closed
mah11 opened this issue May 3, 2019 · 1 comment
Closed

question about clamp terms #36

mah11 opened this issue May 3, 2019 · 1 comment
Assignees
Labels

Comments

@mah11
Copy link
Contributor

mah11 commented May 3, 2019

In #33, @dianeoinglis asked for "FAO:0000061 fused clamp" to become is_a multicellular fungal structure, multicellular organism (now FAO:0002004), but the ontology structure is:

septate hypha
[is_a] clamp cell
-- [part_of] fused clamp
-- [part_of] unfused clamp

It doesn't make sense to have a multicellular structure be part_of a cell, which is what would be implied by adding the fused clamp is_a multicellular structure link.

So I wonder if the structure should be this instead?

septate hypha
[part_of] clamp cell
[is_a] fused clamp
[is_a] unfused clamp

i.e. fused and unfused are types of hyphal clamp, and a clamp cell is part of a hypha. Then the multicellular parent could be added to fused clamp with no nasty consequences.

If this sounds nuts, please bear with me - I'm very much still a beginner at learning fungal anatomy! I can make the changes if they do look OK.

@mah11
Copy link
Contributor Author

mah11 commented Apr 29, 2020

In light of #48, I'm implementing the changes I suggested above. Reopen this, or start a new ticket, if anything looks amiss.

@mah11 mah11 closed this as completed in e676235 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants