Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement comprehensive test before release #2536

Open
shawntanzk opened this issue Jun 16, 2022 · 10 comments
Open

Implement comprehensive test before release #2536

shawntanzk opened this issue Jun 16, 2022 · 10 comments
Assignees

Comments

@shawntanzk
Copy link
Collaborator

Person that is responsible for release should run a comprehensive set of test (we can turn on checks/CI that we turned off)
That way we get informed before release rather than after
This should be a single command (following what Jim has done)

@matentzn
Copy link
Contributor

@balhoff I would like to just copy paste your QC pipeline into the Uberon build process. Can you point me to the makefile again?

@matentzn
Copy link
Contributor

(the one you do the merge of the various master branches)

@matentzn
Copy link
Contributor

So this actually runs in github ci.. tbh, wouldn't it be better if we ran that exact action? Otherwise you have to remember to inform us :D

I think actions cannot send emails (I went through that rabbit whole once, so I am not going there again), but could we have it create an issue on Ubergraph (or anywhere else) that tags the entire tech team (@shawntanzk @ubyndr @anitacaron and @matentzn)?

We can also install this action in one of our repos, whatever is best

@balhoff
Copy link
Member

balhoff commented Jun 17, 2022

I will keep running it in Ubergraph, since integration is the focus for that repo, but you could run it elsewhere, especially if you want to trigger by commit instead of the daily schedule. Creating an issue is a good idea, although it runs every day. How should we stop it from making a new issue every day?

@matentzn
Copy link
Contributor

Of course it should only create an issue if it fails!

@matentzn
Copy link
Contributor

(comment on an issue if one already exists)

@matentzn
Copy link
Contributor

I think if it runs daily, and it just comments on an issue tagging us all, than we will have done the world a big service. I would love extending that to other ontologies moving forward.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Apr 5, 2023
@anitacaron anitacaron removed the Stale label Jun 26, 2023
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants