Fix incompatibility with ZFA's "head". #3360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the "craniocervical region" (UBERON:0007811), comprising the head proper and the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than UBERON:0000033). Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal arches are located in the neck rather than the head. So we create a new term 'embryonic craniocervical region' to be the embryonic counterpart of 'craniocervical region' (as 'embryonic head' is the embryonic counterpart of 'head'), and rewrite the aforementioned axiom to state that 'pharyngeal arch' is part of the 'embryonic craniocervical region'. Combined together, these two changes fix about 80 unsatisfiable classes in the merge product of Uberon and ZFA. closes #379
Not really useful for a definition that is merely the English translation of the logical definition, but it keeps the CI checks happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ZFA, the "head" (ZFA:0001114) corresponds to what Uberon calls the "craniocervical region" (UBERON:0007811), comprising the head proper and the neck. So we remap ZFA:0001114 to UBERON:0007811, rather than UBERON:0000033).
Also, the axiom stating that 'pharyngeal arch' (UBERON:0002539) is part of the 'embryonic head' (UBERON:0008816) is bogus, as some pharyngeal arches are located in the neck rather than the head. So we create a new term 'embryonic craniocervical region' to be the embryonic counterpart of 'craniocervical region' (as 'embryonic head' is the embryonic counterpart of 'head'), and rewrite the aforementioned axiom to state that 'pharyngeal arch' is part of the 'embryonic craniocervical region'.
Combined together, these two changes fix about 80 unsatisfiable classes in the merge product of Uberon and ZFA.
closes #379