You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The odinDataTest integration app calls the frameTests app to run unit test cases against the output HDF5 file written by the FS/FR/FP instances in the test. frameTests is a boost::unit_test application. Recent versions of this framework seem to have changed the way that argument parsing is handled, separating arguments passed to the core application from those passed to the unit test modules with a -- separator. This doesn't seem to be handled correctly by odinDataTest positional argument parsing, yielding failures like the following:
2283 [0x7f28d1073a00] INFO Test.App null - Process to launch: test
An unrecognized parameter in the argument json=/tmp/install/test_config/testUDP.json
The program 'frameTests' is a Boost.Test module containing unit tests.
Usage
frameTests [Boost.Test argument]... [-- [custom test module argument]...]
Use
frameTests --help
or frameTests --help=<parameter name>
for detailed help on Boost.Test parameters.
This problem is seen migrating the CI jobs to Githhub Actions, where the test runners are Ubuntu 20.04 with a more recent boost installation. The log_level argument to frameTests also has to move into the command declaration as it needs to be emitted before any of the module-specific arguments, otherwise it has no effect on the overall boost logging level.
As a work around it was necessary to modify the core command in the configuration file to include some of the arguments, thus:
The
odinDataTest
integration app calls the frameTests app to run unit test cases against the output HDF5 file written by the FS/FR/FP instances in the test. frameTests is aboost::unit_test
application. Recent versions of this framework seem to have changed the way that argument parsing is handled, separating arguments passed to the core application from those passed to the unit test modules with a--
separator. This doesn't seem to be handled correctly byodinDataTest
positional argument parsing, yielding failures like the following:This problem is seen migrating the CI jobs to Githhub Actions, where the test runners are Ubuntu 20.04 with a more recent
boost
installation. Thelog_level
argument toframeTests
also has to move into the command declaration as it needs to be emitted before any of the module-specific arguments, otherwise it has no effect on the overallboost
logging level.As a work around it was necessary to modify the core command in the configuration file to include some of the arguments, thus:
odin-data/test/integrationTest/config/dummyUDP.json
Line 24 in 3530ff0
We should consider reviewing how the argument parsing works in
odinDataTest
to ensure it handles this situation correctly.The text was updated successfully, but these errors were encountered: