Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct owner for /var/lib/odoo #105

Closed
wants to merge 2 commits into from

Conversation

danielmorlock
Copy link

Fixes #104

Make /var/lib/odoo writeable for the odoo user.
&& chown -R odoo /mnt/extra-addons
&& chown -R odoo /mnt/extra-addons ; \
test ! -d /var/lib/odoo && mkdir -p /var/lib/odoo ; \
chown -R odoo /var/lib/odoo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just have:

&& chown -R odoo /var/lib/odoo \
&& chown -R odoo /mnt/extra-addons

That is what I am using (without checking for the existence of the directory first, like you're doing in line 43) .. and it works just fine (and resolves 404 issues when I add all the enterprise modules)

Also there should be no need to check if the dir exists because according to Docker documentation "Volumes are initialized when a container is created"

When you build the image docker creates intermediary containers at which point the volume would be initialized.

@d-fence
Copy link
Contributor

d-fence commented Jan 22, 2020

done since 60b3f82

@d-fence d-fence closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct ownership for /var/lib/odoo
3 participants