Modals.close at doesn't redirect when with params

[FrancoRATOVOSON]

My code looks like this :

modals.close({
  at: '/:income',
  params: {
    income: selectedIncome
  }
})

And it redirect me littrealy to /:income but dont replace the ":income" with selectedIncome. I had to replace it with useNavigate and it worked.
I looked in the codebase and I wonder if the miss of generatePath in the code of modal.close (2) like in Link (1) component could be the origin ?

generouted/packages/react-router/src/client/components.tsx

Lines 7 to 8 in 0cadbbf

	Link: <P extends Path | To<Path>>({ to, params, ...props }: LinkProps<P, Params>) => {
	const path = generatePath(typeof to === 'string' ? to : to.pathname, params || ({} as any))

(1) Link component

generouted/packages/react-router/src/client/hooks.ts

Lines 34 to 36 in 0cadbbf

	close: <P extends Path>(options?: Options<P>) => {
	const { at, state, ...opts } = options || {}
	navigate(at || location.pathname, { ...opts, state: { ...location.state, ...state, modal: '' } })

(2) modal.close function

[oedotme]

@FrancoRATOVOSON Thanks for reporting this. This was indeed an issue related to both modals open and close methods, which the at params weren't resolving at all.

It should be fixed now at v1.18.6, Thanks!