Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non numerical values for debuginfo cannot be parsed from cargo messages #240

Closed
pacak opened this issue Jul 14, 2023 · 1 comment · Fixed by #241
Closed

Non numerical values for debuginfo cannot be parsed from cargo messages #240

pacak opened this issue Jul 14, 2023 · 1 comment · Fixed by #241

Comments

@pacak
Copy link

pacak commented Jul 14, 2023

Valid values for debuginfo level now also include strings "line-tables-only" and "line-directives-only", see here.

cargo will emit those as part of json output. profile for an can look artifact look like this

"profile":{"opt_level":"3","debuginfo":"line-tables-only","debug_assertions":false,"overflow_checks":false,"test":false},

I'm trying to parse it into cargo_metadata::messages::Message datatype and it fails to parse it, probably because
ArtifactProfile defines debuginfo as Option<u32>

pacak/cargo-show-asm#187 - related ticket

@ehuss
Copy link
Contributor

ehuss commented Jul 14, 2023

Oh my, that is not good. I'm sorry, I completely missed this. I'm following up at https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Breaking.20JSON.20change.20in.201.2E71 to discuss this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants