Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening a plot in the cheat sheet containing deleted characters #1082

Closed
Anne501R opened this issue Oct 8, 2022 · 1 comment
Closed
Labels
Milestone

Comments

@Anne501R
Copy link

Anne501R commented Oct 8, 2022

When I open a specific plot in the cheat sheet view, Manuskript crashes. The error log says:

2022-10-08 11:03:13,529 - manuskript.logging - CRITICAL - An unhandled exception has occurred!
Traceback (most recent call last):
  File "manuskript\ui\cheatSheet.py", line 155, in showInfos
  File "manuskript\models\references.py", line 306, in infos
AttributeError: 'NoneType' object has no attribute 'name'

The error occured due to a character that I deleted in the character list, but was still referenced in the 'Basic Info' > 'Character(s)' field of this plot.

Workaround / fix: manually delete empty character reference in 'Basic Infos'

TheJackiMonster added a commit that referenced this issue Feb 10, 2023
Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>
@TheJackiMonster TheJackiMonster added this to the 0.15.0 milestone Feb 10, 2023
@TheJackiMonster
Copy link
Collaborator

Okay, I could reproduce it. The actual issue is likely that a character won't get removed from plots even though it has been deleted. Then the application tries to access a name of an invalid entry.

I've implemented a quick fix for the crash. But the invalid character reference stays for now. However in the newer efforts of refactoring Manuskript this issue should get resolved completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants