Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions Windows CI build to commits #1092

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Add GitHub Actions Windows CI build to commits #1092

merged 8 commits into from
Dec 16, 2022

Conversation

MC42
Copy link
Contributor

@MC42 MC42 commented Dec 15, 2022

This will permit automatic Windows builds in CI/CD when the develop branch has new commits made and/or when people make Pull Requests, to test them. It does not run pytest. The commit hash SHA short will be in the "About" screen of the build artifacts.

Example screenshot demonstrating the hash short version functionality.

image

MC42 and others added 5 commits December 12, 2022 13:54
@MC42
Update build script, maybe?
a99e984
@MC42
Squashed commit of the following:
689804d 
commit a50aff9
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 14:40:59 2022 -0500

    Add install recommends back, forgot it...

commit 8034957
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 14:18:16 2022 -0500

    Try 64 bit builds?

commit 4b624ef
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 13:47:33 2022 -0500

    Remove wineprefix to test.

commit 1dc8cd0
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 13:37:30 2022 -0500

    Swap to staging.

commit eb75093
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 13:28:23 2022 -0500

    printing shit to try and diagnose.

commit c45c47d
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 13:06:48 2022 -0500

    Try winebooting first.

commit 6e618ff
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 12:54:46 2022 -0500

    Try running with xvfb to deal with display issues?

commit cf0b938
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 12:34:27 2022 -0500

    Swapping back to stable I guess?

commit 8b03199
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 12:14:09 2022 -0500

    Fix broken closing bracket.

commit b4d0c7b
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:53:17 2022 -0500

    Fix stupid stub call of wine --version that I put an echo on that wasn't needed...

commit 9632b39
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:46:43 2022 -0500

    Try WineHQ steps after fix patch.

commit af21ddb
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:43:12 2022 -0500

    Add Wine version print.

commit b500ece
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:39:04 2022 -0500

    Alternate name?

commit c2d9b75
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:35:01 2022 -0500

    Swap back to devel (since it goes stable->devel->staging apparently.)

commit 8cc5977
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:30:48 2022 -0500

    Try out wine staging and update python.

commit 33af296
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:30:33 2022 -0500

    Try out wine staging and pray.

commit 551227b
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:25:05 2022 -0500

    Undo mucked syntax.

commit f67edaf
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:24:37 2022 -0500

    Older pandoc test.

commit 728707b
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:23:48 2022 -0500

    Try older pandoc install.

commit 7dee6c0
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:16:07 2022 -0500

    Try to shorten build steps process.

commit f2f9a5b
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:14:52 2022 -0500

    Remove APT cache.

commit 1cdc43a
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:10:10 2022 -0500

    Fix syntax error.

commit 9cc172a
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 11:08:28 2022 -0500

    Try workaround in issue.

commit 6a9f2b3
Author: Kim Chase <me@hi-im.kim>
Date:   Tue Dec 13 10:53:02 2022 -0500

    Regular wine whine.

commit b202e08
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:54:47 2022 -0500

    List sources so I can remove deb.sury.org from stuff.

commit 5bc6d77
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:49:53 2022 -0500

    Try the workaround.

commit 58bee46
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:45:59 2022 -0500

    Try this selector?

commit c11b9b9
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:41:48 2022 -0500

    WIne32 prayer.

commit d1afae7
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:38:30 2022 -0500

    Clear cache and pray.

commit 145d381
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:34:30 2022 -0500

    explicitly install libwine386.

commit f152a63
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:30:31 2022 -0500

    sudo sudo sudo

commit df17f58
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:28:04 2022 -0500

    i386 wine32 prayers.

commit d172b98
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:22:38 2022 -0500

    Swap wine calls to wine64.

commit b56fe9f
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:18:43 2022 -0500

    Tiny tweak.

commit a9c928e
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:16:28 2022 -0500

    Simplify.

commit ef9c94d
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:14:54 2022 -0500

    Update to 22.04 and hoping.

commit 5039fc2
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:12:05 2022 -0500

    Remove WineHQ again I guess.

commit 32f46bb
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:08:45 2022 -0500

    Add multiverse/universe.

commit 10f80d0
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:07:33 2022 -0500

    Reordering and praying.

commit 42be65f
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:05:58 2022 -0500

    Purge.

commit ddb83a8
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:05:20 2022 -0500

    try me.

commit 9214a1b
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 17:02:01 2022 -0500

    Or not...

commit af8eff9
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:59:35 2022 -0500

    Trying to explicitly install amd64 install... we'll see I guess?

commit 5c56958
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:56:08 2022 -0500

    Typo fix.

commit 71c784e
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:54:00 2022 -0500

    Trying to remove MSFT build repo.

commit 48c8506
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:48:08 2022 -0500

    Upgrading first.

commit 3e540cc
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:45:04 2022 -0500

    Wine Ubuntu specific instructions and hoping.

commit ce4b7db
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:42:05 2022 -0500

    Try with install reccomends *this time*.

commit cff2ad1
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:40:10 2022 -0500

    Try again with 386.

commit 25efa15
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:37:46 2022 -0500

    Trying different instructions and hoping.

commit 50fc7d8
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:33:55 2022 -0500

    Install suggests and hope and pray.

commit 928a871
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:31:16 2022 -0500

    Forgot sudo again.

commit 60ab871
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:29:29 2022 -0500

    testing again.

commit 02c4ee7
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:24:16 2022 -0500

    We ball.

commit 0bdf889
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:20:59 2022 -0500

    Trying out modified instructions.

commit 600ab4f
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:16:57 2022 -0500

    Try instructions from Winehq.

commit 487be11
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:12:50 2022 -0500

    Try with just stock wine?

commit e27ec74
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:07:39 2022 -0500

    Trying out winehq-develop step.

commit 2e2a0c9
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:05:14 2022 -0500

    Try rearranging purge and re-install stuff.

commit ea26769
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 16:00:07 2022 -0500

    Remove erroneous procss call.  Embarassing.

commit 10fc0e7
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:57:51 2022 -0500

    Rearrange to try and cache apt from wine too.

commit d11f5b6
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:52:40 2022 -0500

    Fix *all* the calls in section to run as root.... fml.

commit ae10399
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:35:42 2022 -0500

    add sudo to dpkg call.

commit 2507fcc
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:30:25 2022 -0500

    Add installer step to add i386 wine.

commit 0a8a5af
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:25:54 2022 -0500

    Try just re-running i guess.

commit 8f41100
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:22:00 2022 -0500

    Trying to kill latent xvfb that didn't close?

commit c95bc03
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:17:15 2022 -0500

    Fix package name, hopefully it runs.

commit 8bf1f1f
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:11:55 2022 -0500

    Add upgrade step to hopefully help.  We'll see.

commit ea2322c
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:09:39 2022 -0500

    Install Wine from different place?  We'll see.

commit b2642f6
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:05:49 2022 -0500

    Run in xvfb for CI/CD.

commit 208fa49
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 15:00:09 2022 -0500

    Tiny tweaks to fix Wine build issues.

commit 422f589
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:56:18 2022 -0500

    Try with SHA short?

commit e16a23e
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:54:03 2022 -0500

    Swap to forced 64 bit builds (it's 2022, please...)

commit cb8278f
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:51:24 2022 -0500

    Runner is not root.  Continue.

commit c3d27a4
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:50:44 2022 -0500

    Fix silly syntax issue.

commit 8b51550
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:49:38 2022 -0500

    Fix missing Windows Python and continue on.

commit 70a20d0
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:44:26 2022 -0500

    Add wine to apt dependencies.

commit df00da4
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:41:52 2022 -0500

    Forgot to include the ENV step.

commit a6e22d8
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:40:03 2022 -0500

    Testing WINE builds on GH Actions.

commit 2c32e4a
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:39:42 2022 -0500

    Try running windows build script?  i suppose?

commit 9cb7bbd
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:30:10 2022 -0500

    Resolve syntax error #2.  oops.

commit db02840
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:29:39 2022 -0500

    Resolve syntax error... oops.

commit 8f261a7
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:29:08 2022 -0500

    Attempting to cache apt packages for faster builds.

commit f3857d9
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:25:12 2022 -0500

    Attempting to print commit hash inside build.

commit f06d5ad
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:22:09 2022 -0500

    hash based git version test 1.

commit bb19490
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:18:29 2022 -0500

    First test of a linux build in Github CI.

commit 3808c39
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:07:20 2022 -0500

    Indentation on workflow confirm.

commit 194d01a
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:06:38 2022 -0500

    Minor cleanup to make this workflow named properly.

commit c27485c
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:02:22 2022 -0500

    Update to proper version?  Apparently.

commit 66cd703
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 14:00:11 2022 -0500

    Update actions steps.

commit 7c650fb
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 13:57:38 2022 -0500

    Update to python 3.9 for build script.

commit b4111e3
Author: Kim Chase <me@hi-im.kim>
Date:   Mon Dec 12 13:56:12 2022 -0500

    Try removing buggy build options.
@MC42
Merge branch 'olivierkes:develop' into develop
be06f88
@MC42
Trim together Windows build errata.
8caec34
@MC42
Revert Windows build file to what it was at the start of this adventu…
9be0180 
…re to not break anyone else's work.
@TheJackiMonster
Copy link
Collaborator

Looks good but I would recommend to remove some of the libraries after pyinstaller has finished. Because otherwise the build will not work on Windows 7 and Windows 8, I assume. More details here in lines 83 to 91.

Maybe we can even remove more Qt5 libraries from the final build which we don't need, reducing the size further. But at least the files I removed in the script using Wine are necessary as far as I've tested (the exact reasons depend on Windows though... ^^').

Besides do you think it's possible to have a macOS CI via Github actions as well to build a binary? Just in case the travis CI is not able to make a release because I'm not sure whether the FTP server to store the macOS binary still runs. ^^'

@TheJackiMonster
Copy link
Collaborator

I think in case of Qt5 libraries, they have been moved by newer pyinstaller versions into a different subdirectory. So they need to be removed in PyQt5/Qt5/bin/Qt5Bluetooth.dll. I will just correct it.

@TheJackiMonster
Update path of Qt5Bluetooth.dll to be removed
d9b8a56 
Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>
@MC42
Copy link
Contributor Author

MC42 commented Dec 15, 2022

I'll poke at the macOS install build stuff next. If you could, squash merge this, I'll work on that in a branch.

@TheJackiMonster TheJackiMonster merged commit a36bc55 into olivierkes:develop Dec 16, 2022
@TheJackiMonster TheJackiMonster added this to the 0.15.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MC42 @TheJackiMonster