Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor] Implement collector executable updates #33947

Open
BinaryFissionGames opened this issue Jul 8, 2024 · 3 comments
Open
Labels
cmd/opampsupervisor enhancement New feature or request needs triage New item requiring triage

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

This issue is for implementing the "Collector Executable Updates" section of the supervisor spec.

Describe the solution you'd like

See spec for a description of the behavior:

Collector Executable Updates

Note: this capability must be manually enabled by the user via the AcceptsPackages setting in the supervisor config file and is disabled by default.

This capability should be only implemented after we introduce the code signing process for the Collector and all released Collector executables are signed, the Supervisor is capable of verifying the signature of executables and other OpAMP security recommendations are followed.

The Supervisor will download Collector package updates when offered so by the Backend. The Supervisor will verify the integrity of the packages and will install them. This requires stopping the Collector, overwriting the Collector executable file with the newly downloaded version and starting the Collector. Before overwriting the executable the Supervisor will save it in case it is necessary for reverting.

If after the restart the Collector does not become healthy the Supervisor will revert the update, by stopping the Collector, reverting the Collector executable file and starting the Collector again. The failed update attempt will be reported to the Backend and the failed Collector package version will be marked as "bad" to avoid trying it again even if offered by the Backend.

Note: cached local config must be invalidated after executable updates to make sure a fresh AgentDescription is obtained by the Supervisor on the next Collector start (at the minimum the version number to be included in AgentDescription is expected to change after the executable is updated).

Describe alternatives you've considered

No response

Additional context

No response

@BinaryFissionGames BinaryFissionGames added enhancement New feature or request needs triage New item requiring triage labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 9, 2024
@BinaryFissionGames
Copy link
Contributor Author

I am currently working on support for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

2 participants