Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dev environment #598

Merged
merged 18 commits into from
Nov 21, 2022
Merged

Better dev environment #598

merged 18 commits into from
Nov 21, 2022

Conversation

puckpuck
Copy link
Contributor

Fixes #106

Changes

Adds a script and a Makefile command to invoke it. The script will copy the protobuf definitions into the service, and in some cases generate protobuf files for the service.

Copied and generated files are added to .gitignore

@puckpuck puckpuck requested a review from a team as a code owner November 19, 2022 06:18
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor suggestions.

puckpuck and others added 6 commits November 20, 2022 20:57
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
ide-gen-proto.sh Outdated Show resolved Hide resolved
docs/development.md Outdated Show resolved Hide resolved
@austinlparker austinlparker merged commit 9096420 into open-telemetry:main Nov 21, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* local dev protobuf gen script

* remove gen_proto_java

* fix cargo build

* add docs

* add development docs

* add development docs

* fix linter

* Update docs/development.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update docs/development.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update docs/development.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update docs/development.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Update docs/development.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* alpha order c++ pre-requisites

* use python3

* add protoc-gen-go / grpc

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add protoc command to Makefile
4 participants