-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better dev environment #598
Merged
austinlparker
merged 18 commits into
open-telemetry:main
from
puckpuck:better_dev_environment
Nov 21, 2022
Merged
Better dev environment #598
austinlparker
merged 18 commits into
open-telemetry:main
from
puckpuck:better_dev_environment
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Nov 21, 2022
reyang
reviewed
Nov 21, 2022
reyang
reviewed
Nov 21, 2022
reyang
reviewed
Nov 21, 2022
reyang
reviewed
Nov 21, 2022
reyang
reviewed
Nov 21, 2022
reyang
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor suggestions.
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
julianocosta89
approved these changes
Nov 21, 2022
austinlparker
approved these changes
Nov 21, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* local dev protobuf gen script * remove gen_proto_java * fix cargo build * add docs * add development docs * add development docs * fix linter * Update docs/development.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update docs/development.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update docs/development.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update docs/development.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Update docs/development.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * alpha order c++ pre-requisites * use python3 * add protoc-gen-go / grpc Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
Changes
Adds a script and a Makefile command to invoke it. The script will copy the protobuf definitions into the service, and in some cases generate protobuf files for the service.
Copied and generated files are added to
.gitignore