Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /pb/google/protobuf/Timestamp.proto #107

Closed
mic-max opened this issue Jun 4, 2022 · 2 comments · Fixed by #547
Closed

Remove /pb/google/protobuf/Timestamp.proto #107

mic-max opened this issue Jun 4, 2022 · 2 comments · Fixed by #547
Assignees
Labels
enhancement New feature or request

Comments

@mic-max
Copy link
Contributor

mic-max commented Jun 4, 2022

Feature Request

This was added as a hacky way to get around protobuf compilation errors while migrating from keeping copies of demo.proto in the repository along with the language specific files/classes generated from the aforementioned proto file.

Installing protoc using apk might not be setting the include path correctly to this directory, which should be included with the install: https://github.com/protocolbuffers/protobuf/tree/main/src/google

The only needed file was Timestamp.proto so that's the only one we copied over.

Consider

@mic-max mic-max added the enhancement New feature or request label Jun 4, 2022
@cartersocha
Copy link
Contributor

Is this still needed? Closing for now

@mic-max
Copy link
Contributor Author

mic-max commented Oct 7, 2022

Yes. Ideally this file: https://github.com/open-telemetry/opentelemetry-demo/blob/main/pb/google/protobuf/timestamp.proto should not be part of this repository. Moreso, just a nice to do thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants