-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy opentelemetry-microservices-demo to opentelemetry-demo-webstore #14
Comments
Thanks @julianocosta89! Here are the additional items we need to consider:
|
I think so (?), though I'm not an expert at this. @lizthegrey and possibly @tedsuo know way more about this than I do. |
OpenTelemetry community would prefer the copyright to be "OpenTelemetry Authors" - https://github.com/open-telemetry/community/blob/4b53b7ffb6390e57850e9a916bd63253349a7770/CONTRIBUTING.md#copyright-notices. But this has to be blessed by the previous author(s) (I think they have the ultimate saying, unless it's documented in a different way). Here goes an example - I worked with .NET Foundation and the ASP.NET team to get their bless on open-telemetry/opentelemetry-dotnet#2225. There are different examples - e.g. .NET auto-instrumentation https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/src/OpenTelemetry.AutoInstrumentation.Native/lib/fmt_x64-windows-static/share/fmt/copyright. |
What @reyang said. |
Here goes a summary of existing copyright info (by scanning through the temporary Copyright Copyright © Copyright Copyright |
In this case, since it's forking a long-established project, I think we credit OpenTelemetry Authors for any significant modifications, but we leave the existing copyrights alone. |
Based on my investigation, it seems everything in the current The copyright information shouldn't be a blocker if we follow what @lizthegrey suggested. |
Great thanks for the help. @julianocosta89 we should be okay from a licensing perspective. We'll follow Liz's guidance |
@julianocosta89 I think steps 3 & 4 are now done. Please review then complete the merge if possible |
Just merged the pr into main & deleted the branch. Closing this issue. |
This has been discussed during the OpenTelemetry Demo Application SIG Meeting.
Here are the steps that we will be following:
online-boutique
online-boutique
FYI: @open-telemetry/demo-webstore-maintainers
The text was updated successfully, but these errors were encountered: