Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy opentelemetry-microservices-demo to opentelemetry-demo-webstore #14

Closed
6 tasks done
julianocosta89 opened this issue May 12, 2022 · 11 comments · Fixed by #15
Closed
6 tasks done

Copy opentelemetry-microservices-demo to opentelemetry-demo-webstore #14

julianocosta89 opened this issue May 12, 2022 · 11 comments · Fixed by #15
Assignees

Comments

@julianocosta89
Copy link
Member

julianocosta89 commented May 12, 2022

This has been discussed during the OpenTelemetry Demo Application SIG Meeting.

Here are the steps that we will be following:

  • Create branch online-boutique
  • Copy the code as-is from opentelemetry-microservices-demo
  • Make minimum changes to clean up unnecessary parts (istio, cloudbuild and some docs)
  • Update changelog
  • Merge branch into main
  • Delete branch online-boutique

FYI: @open-telemetry/demo-webstore-maintainers

@julianocosta89 julianocosta89 self-assigned this May 12, 2022
@julianocosta89 julianocosta89 linked a pull request May 12, 2022 that will close this issue
@reyang
Copy link
Member

reyang commented May 12, 2022

Thanks @julianocosta89!

Here are the additional items we need to consider:

  1. Confirm with the original author(s) regarding licensing / copyright.
  2. Check if there are licensing / copyright issues related to dependencies / submodules / etc.
  3. Decide how much history / changelog are we going to keep.
  4. Do we need to preserve the commit history from the original source? (I guess the answer is no - by looking at other donations to OpenTelemetry).

@cartersocha
Copy link
Contributor

@mtwo, @jsuereth, can you provide guidance on the licensing / copyright changes we should be making. I think our preference is for the copyright owners to be OpenTelemetry itself right, @reyang?

@mtwo
Copy link
Member

mtwo commented May 12, 2022

I think so (?), though I'm not an expert at this. @lizthegrey and possibly @tedsuo know way more about this than I do.

@reyang
Copy link
Member

reyang commented May 12, 2022

OpenTelemetry community would prefer the copyright to be "OpenTelemetry Authors" - https://github.com/open-telemetry/community/blob/4b53b7ffb6390e57850e9a916bd63253349a7770/CONTRIBUTING.md#copyright-notices. But this has to be blessed by the previous author(s) (I think they have the ultimate saying, unless it's documented in a different way).

Here goes an example - I worked with .NET Foundation and the ASP.NET team to get their bless on open-telemetry/opentelemetry-dotnet#2225.

There are different examples - e.g. .NET auto-instrumentation https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/src/OpenTelemetry.AutoInstrumentation.Native/lib/fmt_x64-windows-static/share/fmt/copyright.

@lizthegrey
Copy link
Member

What @reyang said.

@lizthegrey
Copy link
Member

In this case, since it's forking a long-established project, I think we credit OpenTelemetry Authors for any significant modifications, but we leave the existing copyrights alone.

@reyang
Copy link
Member

reyang commented May 12, 2022

Based on my investigation, it seems everything in the current online-boutique branch should be compatible with Apache License, Version 2.0 (disclaimer: I'm not an attorney).

The copyright information shouldn't be a blocker if we follow what @lizthegrey suggested.

@cartersocha
Copy link
Contributor

Great thanks for the help. @julianocosta89 we should be okay from a licensing perspective. We'll follow Liz's guidance

@cartersocha
Copy link
Contributor

@julianocosta89 I think steps 3 & 4 are now done. Please review then complete the merge if possible

@cartersocha
Copy link
Contributor

Just merged the pr into main & deleted the branch. Closing this issue.

alanwest added a commit to alanwest/opentelemetry-demo that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants