Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[featureflag] - Dockerfile should build protobuf modules #279

Closed
3 tasks
puckpuck opened this issue Aug 10, 2022 · 2 comments · Fixed by #599
Closed
3 tasks

[featureflag] - Dockerfile should build protobuf modules #279

puckpuck opened this issue Aug 10, 2022 · 2 comments · Fixed by #599
Labels
enhancement New feature or request

Comments

@puckpuck
Copy link
Contributor

puckpuck commented Aug 10, 2022 •
edited
Loading

Feature Request

Update Dockerfile to build artifacts similar to how other services are built.

  • Use the top-level build context, updating paths in Dockerfile accordingly
  • Copy the top-level demo.proto file into the appropriate build location
  • Run rebar3 grpc gen as part of the build

cc @tsloughter
@puckpuck puckpuck added the enhancement New feature or request label Aug 10, 2022
@puckpuck puckpuck mentioned this issue Aug 10, 2022
Merged
1 task
@cartersocha
Copy link
Contributor

Can we close this @puckpuck ?

@puckpuck
Copy link
Contributor Author

#599 will close this

@puckpuck puckpuck mentioned this issue Nov 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[featureflag] - Move protobuf file generation to docker build
2 participants
@puckpuck @cartersocha