Exit featureflagservice startup script if migrations fail #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshleecreates
force-pushed
the
issue-398-feature-flag-k8s-migrations
branch
from
60a7f7a
to
6e6d3a6
Compare
puckpuck
requested changes
Oct 6, 2022
joshleecreates
force-pushed
the
issue-398-feature-flag-k8s-migrations
branch
from
6e6d3a6
to
7018dc7
Compare
puckpuck
approved these changes
Oct 6, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398 .
Changes
Changes the startup shell script for the feature flag service to exit with a failure code if the migration command fails. This causes the pod to be automatically restarted in Kubernetes. In my tests, it always restarts once before successfully connecting to the database.