Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images support multi arch #488

Merged
merged 17 commits into from
Oct 19, 2022
Merged

Images support multi arch #488

merged 17 commits into from
Oct 19, 2022

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Oct 19, 2022

Fixes #458

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
@JaredTan95 JaredTan95 requested a review from a team as a code owner October 19, 2022 10:35
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but you need to bring the release tag automation back in.

.github/workflows/release.yml Outdated Show resolved Hide resolved
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinlparker austinlparker merged commit 3c244ca into open-telemetry:main Oct 19, 2022
@JaredTan95 JaredTan95 deleted the images_support_multi_arch branch October 20, 2022 00:45
austinlparker added a commit that referenced this pull request Oct 20, 2022
austinlparker added a commit that referenced this pull request Oct 20, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* spoort multiarch release

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* update

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* debug

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* update

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* remove tag

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* update

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* remove update env file

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* note login

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* debug

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* finish

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* update changelog

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* update

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* polish

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* typo

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

* revert update .env

Signed-off-by: Jared Tan <jian.tan@daocloud.io>

Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Co-authored-by: Austin Parker <austin@ap2.io>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce multi-arch/platform images and improve build times.
3 participants