From c32e2505b6c2b7914212f0a84a938ae53d8eaf0a Mon Sep 17 00:00:00 2001 From: Gustavo Pantuza Date: Fri, 8 Dec 2023 18:46:32 -0300 Subject: [PATCH 1/5] Modifies file permission to be 0644 (we don't need execution for a yaml file) --- chloggen/cmd/new.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chloggen/cmd/new.go b/chloggen/cmd/new.go index d184c47f..9089c05f 100644 --- a/chloggen/cmd/new.go +++ b/chloggen/cmd/new.go @@ -46,7 +46,7 @@ func newCmd() *cobra.Command { if err != nil { return err } - err = os.WriteFile(pathWithExt, templateBytes, os.FileMode(0755)) + err = os.WriteFile(pathWithExt, templateBytes, os.FileMode(0644)) if err != nil { return err } From 2193f78936396f916274d4570f91face057ee0c0 Mon Sep 17 00:00:00 2001 From: Gustavo Pantuza Date: Fri, 8 Dec 2023 19:04:24 -0300 Subject: [PATCH 2/5] Adds Changelog entry about chloggen files permissions --- .chloggen/permissions-with-no-execution.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .chloggen/permissions-with-no-execution.yaml diff --git a/.chloggen/permissions-with-no-execution.yaml b/.chloggen/permissions-with-no-execution.yaml new file mode 100644 index 00000000..b3f651d1 --- /dev/null +++ b/.chloggen/permissions-with-no-execution.yaml @@ -0,0 +1,16 @@ +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: + +# The name of the component, or a single word describing the area of concern, (e.g. crosslink) +component: + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: + +# One or more tracking issues related to the change +issues: [] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: From 7c55ed54b2626484f2672080de8237805c210eb6 Mon Sep 17 00:00:00 2001 From: Gustavo Pantuza Date: Fri, 8 Dec 2023 19:16:10 -0300 Subject: [PATCH 3/5] Updates changelog entry with Pull Request ID --- .chloggen/permissions-with-no-execution.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.chloggen/permissions-with-no-execution.yaml b/.chloggen/permissions-with-no-execution.yaml index b3f651d1..631d624e 100644 --- a/.chloggen/permissions-with-no-execution.yaml +++ b/.chloggen/permissions-with-no-execution.yaml @@ -1,14 +1,14 @@ # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' -change_type: +change_type: bug_fix # The name of the component, or a single word describing the area of concern, (e.g. crosslink) -component: +component: chloggen # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). -note: +note: Updates generated files permissions from 0755 to 0644 # One or more tracking issues related to the change -issues: [] +issues: [457] # (Optional) One or more lines of additional information to render under the primary note. # These lines will be padded with 2 spaces and then inserted directly into the document. From 74866eee8d66106f018625beeb9fb518c1630c08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Sat, 9 Dec 2023 00:52:44 +0100 Subject: [PATCH 4/5] Update permissions-with-no-execution.yaml --- .chloggen/permissions-with-no-execution.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.chloggen/permissions-with-no-execution.yaml b/.chloggen/permissions-with-no-execution.yaml index 631d624e..8eca0b68 100644 --- a/.chloggen/permissions-with-no-execution.yaml +++ b/.chloggen/permissions-with-no-execution.yaml @@ -5,7 +5,7 @@ change_type: bug_fix component: chloggen # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). -note: Updates generated files permissions from 0755 to 0644 +note: Change generated files permissions from 0755 to 0644. # One or more tracking issues related to the change issues: [457] From ba2b497baa4b19c9f43e41d5c55fd7375159defc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Sat, 9 Dec 2023 00:53:36 +0100 Subject: [PATCH 5/5] Update permissions-with-no-execution.yaml --- .chloggen/permissions-with-no-execution.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.chloggen/permissions-with-no-execution.yaml b/.chloggen/permissions-with-no-execution.yaml index 8eca0b68..dd357a79 100644 --- a/.chloggen/permissions-with-no-execution.yaml +++ b/.chloggen/permissions-with-no-execution.yaml @@ -5,7 +5,7 @@ change_type: bug_fix component: chloggen # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). -note: Change generated files permissions from 0755 to 0644. +note: change generated files permissions from 0755 to 0644 # One or more tracking issues related to the change issues: [457]