Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify B3 options #2053

Closed
mwear opened this issue Mar 29, 2021 · 1 comment · Fixed by #2054
Closed

Simplify B3 options #2053

mwear opened this issue Mar 29, 2021 · 1 comment · Fixed by #2054
Assignees

Comments

@mwear
Copy link
Member

mwear commented Mar 29, 2021

We can streamline b3 propagation based on this spec issue: open-telemetry/opentelemetry-specification#1562 (comment).

Right now we have three b3 propagator variants.

  • We have a B3Propagator that extracts b3 single and b3 multi, and injects b3 single, but is configurable to inject b3 multi; this is technically spec compliant
  • We have a B3SinglePropagator that exclusively injects and extracts b3 single
  • We have a B3MultiPropagator that exclusively injects and extracts b3 multi

Based on the discussion on the spec PR, there is not really a use case where we'd want to only extract one b3 format; we always want to extract both single and multi. I think we can remove the B3Propagator and update the B3SinglePropagator and B3MultiPropagator to extract both formats.

@mwear mwear self-assigned this Mar 29, 2021
@mwear
Copy link
Member Author

mwear commented Mar 29, 2021

After taking a second look our implementation, I like the B3Propagator as the public interface for b3. I think we should probably treat the B3SinglePropagator and B3MultiPropagator as implementation details leave them unexported.

@mwear mwear changed the title Update B3 propagation for spec compliance Simplify B3 options Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant