Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop extra attributes per event and link #3649

Closed
mohitk05 opened this issue Mar 1, 2023 · 3 comments
Closed

Drop extra attributes per event and link #3649

mohitk05 opened this issue Mar 1, 2023 · 3 comments
Labels
feature-request spec-feature This is a request to implement a new feature which is already specified by the OTel specification stale

Comments

@mohitk05
Copy link
Contributor

mohitk05 commented Mar 1, 2023

The new environment variables OTEL_SPAN_ATTRIBUTE_PER_EVENT_COUNT_LIMIT and OTEL_SPAN_ATTRIBUTE_PER_LINK_COUNT_LIMIT were added in #3576 but they are not currently used. When supplied, the limits should be applied to the attributes being added to any event or link attached to a span.

Check the Span.ts file to get started, the addEvent method would be right place to implement this logic.
@Flarna Flarna added the spec-feature This is a request to implement a new feature which is already specified by the OTel specification label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 1, 2023
@Flarna Flarna removed the stale label May 2, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jul 3, 2023
@github-actions
Copy link

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request spec-feature This is a request to implement a new feature which is already specified by the OTel specification stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flarna @mohitk05