From 0e6dbd06bdb9b4eb8f570ddb36b5ccbd9d7cf597 Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Tue, 4 Jun 2024 10:00:49 -0400 Subject: [PATCH 1/2] refactor(examples/otlp-exporter-node): use new exported string constants for semconv --- examples/otlp-exporter-node/metrics.js | 4 ++-- examples/otlp-exporter-node/tracing.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/otlp-exporter-node/metrics.js b/examples/otlp-exporter-node/metrics.js index 0594ba42e3..22507ef528 100644 --- a/examples/otlp-exporter-node/metrics.js +++ b/examples/otlp-exporter-node/metrics.js @@ -13,7 +13,7 @@ const { } = require('@opentelemetry/sdk-metrics'); const { Resource } = require('@opentelemetry/resources'); const { - SemanticResourceAttributes, + SEMRESATTRS_SERVICE_NAME, } = require('@opentelemetry/semantic-conventions'); // Optional and only needed to see the internal diagnostic logging (during development) @@ -36,7 +36,7 @@ const expHistogramView = new View({ // Create an instance of the metric provider const meterProvider = new MeterProvider({ resource: new Resource({ - [SemanticResourceAttributes.SERVICE_NAME]: 'basic-metric-service', + [SEMRESATTRS_SERVICE_NAME]: 'basic-metric-service', }), views: [expHistogramView], }); diff --git a/examples/otlp-exporter-node/tracing.js b/examples/otlp-exporter-node/tracing.js index d2a6414442..475665f23c 100644 --- a/examples/otlp-exporter-node/tracing.js +++ b/examples/otlp-exporter-node/tracing.js @@ -2,7 +2,7 @@ const { BasicTracerProvider, ConsoleSpanExporter, SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base'); const { Resource } = require('@opentelemetry/resources'); -const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions'); +const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions'); const { diag, trace, @@ -24,7 +24,7 @@ const exporter = new OTLPTraceExporter({ const provider = new BasicTracerProvider({ resource: new Resource({ - [SemanticResourceAttributes.SERVICE_NAME]: 'basic-service', + [SEMRESATTRS_SERVICE_NAME]: 'basic-service', }), }); provider.addSpanProcessor(new SimpleSpanProcessor(exporter)); From 673cd9ab3f939f47bef42f5226fc53308d351e52 Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Tue, 4 Jun 2024 11:33:10 -0400 Subject: [PATCH 2/2] added changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6e31bc077..df0e09d5df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/ ### :books: (Refine Doc) * refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic +* refactor(examples): use new exported string constants for semconv in examples/otlp-exporter-node [#4762](https://github.com/open-telemetry/opentelemetry-js/pull/4762) @Zen-cronic ### :house: (Internal)