Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics API #48

Closed
c24t opened this issue Jul 16, 2019 · 2 comments
Closed

Add metrics API #48

c24t opened this issue Jul 16, 2019 · 2 comments
Assignees
@lzchen
Labels
api Affects the API package.
Milestone
Alpha Release

Comments

@c24t
Copy link
Member

c24t commented Jul 16, 2019

Add the top-level metrics API package. See:
@c24t c24t added the api Affects the API package. label Jul 16, 2019
@Oberon00 Oberon00 mentioned this issue Aug 8, 2019
Closed
@Oberon00 Oberon00 added this to the Alpha Release milestone Sep 13, 2019
@lzchen
Copy link
Contributor

lzchen commented Sep 19, 2019

[#87] RFC 0003
[#136] RFC 0003 cont'd
[#140] RFC 0009

@lzchen lzchen mentioned this issue Sep 19, 2019
Closed
@lzchen lzchen self-assigned this Sep 19, 2019
@c24t
Copy link
Member Author

c24t commented Oct 11, 2019

Closing this one out since we have metrics in the API package, exporters and aggregation will happen in the SDK.

@c24t c24t closed this as completed Oct 11, 2019
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
✨ Add Sampler API (open-telemetry#48)
5245015 
* Add Sampler API

* Keep Optional SpanContext only to make sampling decision

* Add ProbabilitySampler

* Add ProbabilitySampler

* Make probability private and implement probability sampler

* Add test - should sample based on the probability

* Minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
api Affects the API package.
Projects
None yet
Milestone
Alpha Release
Development

No branches or pull requests
3 participants
@Oberon00 @lzchen @c24t