Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No spec for HTTP specific metrics #738

Closed
gfuller1 opened this issue Jul 24, 2020 · 2 comments
Closed

No spec for HTTP specific metrics #738

gfuller1 opened this issue Jul 24, 2020 · 2 comments
Labels
area:api Cross language API specification issue area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@gfuller1
Copy link
Contributor

Problem: There's no standard around what metric instruments to use or what labels to use for capturing HTTP activity. This can lead to problems when trying to navigate the data or filter it.

Example: one instrumented framework captures HTTP information and reports a metric for its duration as http.duration and include a label for the response code response_code. Another instrumented framework captures HTTP information and reports a metric for its duration as http.client.request.duration and includes a label for the response code but it is status_code. When someone tries to filter their data for HTTP metrics they will have a poor experience due to the inconsistencies in the data.

Solution: Write a spec to describe how to create HTTP metrics.

@gfuller1 gfuller1 added the spec:metrics Related to the specification/metrics directory label Jul 24, 2020
@carlosalberto carlosalberto added area:semantic-conventions Related to semantic conventions area:api Cross language API specification issue labels Jul 28, 2020
@bogdandrutu bogdandrutu added the priority:p2 Medium priority level label Jul 28, 2020
@andrewhsu andrewhsu added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 28, 2020
@tigrannajaryan
Copy link
Member

After merging #739 there are now conventions for HTTP metrics. Do we need something else in addition in the spec?

@jmacd
Copy link
Contributor

jmacd commented Sep 9, 2020

I think nothing else is needed here.

@jmacd jmacd closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue area:semantic-conventions Related to semantic conventions priority:p2 Medium priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

6 participants