Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token errors should specify CurrencyId #764

Open
gregdhill opened this issue Jun 8, 2022 · 1 comment
Open

Token errors should specify CurrencyId #764

gregdhill opened this issue Jun 8, 2022 · 1 comment

Comments

@gregdhill
Copy link
Contributor

Some of the errors in orml_tokens::Error could specify the CurrencyId to narrow the source of error. For example, BalanceTooLow could be a tuple variant BalanceTooLow(T::CurrencyId).
@xlc
Copy link
Member

xlc commented Jun 8, 2022 •
edited
Loading

Additional error payload can only be up to 4 bytes and we can't restrict the max size of CurrencyId

paritytech/substrate#10242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlc @gregdhill