[WIP] Pre-Commit: Clang-Format CXX Endings #1228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`identify` used to detect our files does not catch all our file endings.
ax3l
commented
Mar 14, 2022
| @@ -68,6 +68,8 @@ repos: | |||
| rev: v13.0.1 | |||
| hooks: | |||
| - id: clang-format | |||
| types: [file] | |||
| files: '.*\.(c|cpp|cxx|h|hpp|tpp)(\.in)?$' | |||
There was a problem hiding this comment.
This does not yet seem to work 🤔
Should be python regex: https://pre-commit.com/#regular-expressions
There was a problem hiding this comment.
Once this works, I to also need to add .json here as we use this for json formatting as well #1222
|
You were right, |
|
Otherwise, this PR has been mainly obsoleted by #1403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identifyused to detect our files does not catch all our file endings.Refs.: